Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secinfo filter from user settings dialog and elsewhere #2495

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Remove secinfo filter from user settings dialog and elsewhere #2495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04b48ac
Remove secinfo filter from dialog and remove the variable from other …
saberlynx Oct 6, 2020
d424edf
Remove translations
saberlynx Oct 6, 2020
cbf5003
Update CHANGELOG.md
saberlynx Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Only show schedule options in advanced and modify task wizard if user has correct permissions [#2472](https://github.com/greenbone/gsa/pull/2472)

### Removed
- Remove secinfo filter from user settings dialog and elsewhere [#2495](https://github.com/greenbone/gsa/pull/2495)
- Removed export/download for report formats [#2427](https://github.com/greenbone/gsa/pull/2427)

[20.8.1]: https://github.com/greenbone/gsa/compare/v20.8.0...gsa-20.08
Expand Down
1 change: 0 additions & 1 deletion gsa/public/locales/gsa-de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,7 +1438,6 @@
"Search by content": "Suche nach Inhalt",
"SecInfo": "Sicherheitsinfos",
"SecInfo Displays": "SecInfo-Anzeigen",
"SecInfo Filter": "Alle-Sicherheitsinfos-Filter",
"Secret Key": "Geheimer Schlüssel",
"Security note: The SMB protocol does not offer a fingerprint to establish complete mutual trust. Thus a man-in-the-middle attack can not be fully prevented.": "Sicherheitshinweis: Das SMB-Protokoll bietet keinen Fingerprint an, um komplettes gegenseitiges Vertrauen herzustellen. Ein Man-in-the-Middle-Angriff kann somit nicht völlig ausgeschlossen werden.",
"Select": "Auswählen",
Expand Down
4 changes: 0 additions & 4 deletions gsa/src/web/pages/usersettings/dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ let UserSettingsDialog = ({
ovalFilter,
certBundFilter,
dfnCertFilter,
secInfoFilter,
onClose,
onSave,
capabilities,
Expand Down Expand Up @@ -177,7 +176,6 @@ let UserSettingsDialog = ({
ovalFilter,
certBundFilter,
dfnCertFilter,
secInfoFilter,
};

const validationSchema = {
Expand Down Expand Up @@ -297,7 +295,6 @@ let UserSettingsDialog = ({
ovalFilter={values.ovalFilter}
certBundFilter={values.certBundFilter}
dfnCertFilter={values.dfnCertFilter}
secInfoFilter={values.secInfoFilter}
filters={filters}
onChange={onValueChange}
/>
Expand Down Expand Up @@ -367,7 +364,6 @@ UserSettingsDialog.propTypes = {
scannersFilter: PropTypes.string,
schedules: PropTypes.array,
schedulesFilter: PropTypes.string,
secInfoFilter: PropTypes.string,
severityClass: PropTypes.string,
tagsFilter: PropTypes.string,
targets: PropTypes.array,
Expand Down
10 changes: 0 additions & 10 deletions gsa/src/web/pages/usersettings/filterpart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const FilterPart = ({
ovalFilter,
certBundFilter,
dfnCertFilter,
secInfoFilter,
filters = [],
onChange,
}) => {
Expand Down Expand Up @@ -355,14 +354,6 @@ const FilterPart = ({
onChange={onChange}
/>
</FormGroup>
<FormGroup title={_('SecInfo Filter')} titleSize="3">
<Select
name="secInfoFilter"
value={secInfoFilter}
items={renderSelectItems(filterFilters(filters, 'info'), UNSET_VALUE)}
onChange={onChange}
/>
</FormGroup>
</React.Fragment>
);
};
Expand Down Expand Up @@ -392,7 +383,6 @@ FilterPart.propTypes = {
rolesFilter: PropTypes.string,
scannersFilter: PropTypes.string,
schedulesFilter: PropTypes.string,
secInfoFilter: PropTypes.string,
tagsFilter: PropTypes.string,
targetsFilter: PropTypes.string,
tasksFilter: PropTypes.string,
Expand Down