Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure the path to the redis socket #256

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Allow to configure the path to the redis socket #256

merged 2 commits into from
Aug 14, 2019

Conversation

bjoernricks
Copy link
Contributor

Add a new CMake directive (-DREDIS_SOCKET_PATH=/path/to/socket)to allow
to set the path to the redis unix socket at build time.

Additionally change the default path to use the default socket path of
redis on debian and ubuntu which is (/var)/run/redis/redis.sock.

Add a new CMake directive (-DREDIS_SOCKET_PATH=/path/to/socket)to allow
to set the path to the redis unix socket at build time.

Additionally change the default path to use the default socket path of
redis on debian and ubuntu which is (/var)/run/redis/redis.sock.
@bjoernricks bjoernricks marked this pull request as ready for review August 14, 2019 08:27
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK. Not sure what you mean by "(/var)" in the description, because I don't see how /var would ever be added to the path.

@bjoernricks
Copy link
Contributor Author

This looks OK. Not sure what you mean by "(/var)" in the description, because I don't see how /var would ever be added to the path.

Because the redis-server systemd service file uses /var/run/... but /var/run is just a symlink to /run nowadays 😑

@bjoernricks bjoernricks merged commit 8253122 into greenbone:master Aug 14, 2019
@bjoernricks bjoernricks deleted the redis-socket-path branch August 14, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants