Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ConnectionRefusedError on startup when no broker is running #247

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

Kraemii
Copy link
Member

@Kraemii Kraemii commented Aug 8, 2022

What:
Notus-scanner exits now with a log message instead of an exception
SC-650

Why:
In case no MQTT broker was running, the notus-scanner would end with a ConnectionRefuseError as a exception. Now a log message is printed instead

How:
Start notus-scanner without having a MQTT broker running

Checklist:

@Kraemii Kraemii requested a review from a team August 8, 2022 10:55
@Kraemii Kraemii enabled auto-merge (squash) August 8, 2022 10:56
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #247 (9056b2b) into main (8c7aad2) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 9056b2b differs from pull request most recent head 340dbd2. Consider uploading reports for the commit 340dbd2 to get more accurate results

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files          25       25           
  Lines        1096     1096           
  Branches      141      141           
=======================================
  Hits          773      773           
  Misses        302      302           
  Partials       21       21           
Impacted Files Coverage Δ
notus/scanner/daemon.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Kraemii Kraemii merged commit ace8d88 into main Aug 18, 2022
@Kraemii Kraemii deleted the fix-ConnectionRefusedError branch August 18, 2022 07:54
@ArnoStiefvater ArnoStiefvater added the backport-to-stable Backport PR to stable branch label Aug 18, 2022
mergify bot pushed a commit that referenced this pull request Aug 18, 2022
ArnoStiefvater pushed a commit that referenced this pull request Aug 18, 2022
… (#260)

(cherry picked from commit ace8d88)

Co-authored-by: Christoph Krämer <christoph.kraemer@greenbone.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-stable Backport PR to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants