Handle string encoding conversion fail #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a failed conversion was not cought which meant Null was supplied to kb_item_push_str which resulted in a segfault. kb_item_push_str will also be made more resilient on gvm-libs side.
bjoernricks
reviewed
Dec 8, 2021
jjnicola
approved these changes
Dec 9, 2021
jjnicola
changed the title
Kraemii
approved these changes
Dec 9, 2021
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2021
Previously a failed conversion was not cought which meant Null was supplied to kb_item_push_str which resulted in a segfault. kb_item_push_str will also be made more resilient on gvm-libs side. (cherry picked from commit 15f04b4)
mergify bot
pushed a commit
that referenced
this pull request
Dec 9, 2021
Previously a failed conversion was not cought which meant Null was supplied to kb_item_push_str which resulted in a segfault. kb_item_push_str will also be made more resilient on gvm-libs side. (cherry picked from commit 15f04b4) # Conflicts: # misc/plugutils.c
ArnoStiefvater
pushed a commit
that referenced
this pull request
Dec 13, 2021
ArnoStiefvater
added a commit
that referenced
this pull request
Dec 13, 2021
Previously a failed conversion was not cought which meant Null was supplied to kb_item_push_str which resulted in a segfault. kb_item_push_str will also be made more resilient on gvm-libs side. (cherry picked from commit 15f04b4)
ArnoStiefvater
pushed a commit
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Handle string encoding converison fail
Why:
Previously a failed conversion was not cought
which meant Null was supplied to
kb_item_push_strwhich resulted in a segfault.
kb_item_push_strwill also be made more resilienton gvm-libs side with a seperate PR.
How:
Checklist: