Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine linux support #82

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ramijebara
Copy link
Contributor

@ramijebara ramijebara commented Nov 15, 2023

What

These changes represent an integration of existing community work that I have used to add support for an Alpine Linux Docker Build.

The bases for the work comes from the Alpine Community Repository changes.

This work was tested on AMD64 and ARM64 CPU architectures.

Why

The Debian slim based container usually fails compliance scans due to outdated packages or known vulnerabilities. Alpine is more lightweight and will pass compliance container scans more often then not.

References

This change was initially proposed in PR#81

jira issue reference: SC-953 SC-961 // this line was added by ArnoStiefvater

@ramijebara ramijebara requested review from a team as code owners November 15, 2023 16:00
@ArnoStiefvater
Copy link
Member

Hey @ramijebara,

Thanks again for this PR!

I personally think that this is a pretty good idea but need more information first to be able to weigh the consequences.

How does your current deployment look like in which you use the openvas-smb image?
Do you run the other openvas components (openvas-scanner, gvm-libs, ospd-openvas, notus-scanner) also with alpine based images?

I have looked into https://git.alpinelinux.org/aports/tree/community and our other components are also present there.
Would you be willing to add and maintain support for alpine based images for those repos too if we decide to generally add alpine as supported platform? Else there would only be Alpine available for openvas-smb. We would like to either have all our components support Alpine or None, else its very inconsistent which is not something we want. Unfortunately we currently do not have the resources to support 2 platforms for the community on our own.

@ramijebara
Copy link
Contributor Author

Hi @ArnoStiefvater

You are welcome!

Deployment is docker based, all alpine based. Though we are fans of Debian, we find alpine images lighter and easier to maintain when doing continuous security and compliance scans.

I do not use or run any other Openvas components at this time.

I do understand where you are coming from about consistency. I would have the same concern, to be honest.

Since I am not familiar with the other Openvas components, Can I take a look and get back to you by the end of the week?

@jjnicola jjnicola mentioned this pull request Nov 22, 2023
@ArnoStiefvater
Copy link
Member

Sure, the repos/components are: openvas-scanner, gvm-libs and ospd-openvas. notus-scanner is actually not needed for us.

I also would like to mention that we have reverted your PR #83 with #84. See the description for details. If this is not sufficient enough please let me know if you have an alternative solution in mind. Please create a new issue for discussion if needed/wanted.

@ramijebara
Copy link
Contributor Author

ramijebara commented Nov 24, 2023

Hi @ArnoStiefvater sure, I will take a look at those 3 projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants