Sign seal #83
Merged
Sign seal #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtsfrei
approved these changes
Nov 16, 2023
ArnoStiefvater
added a commit
that referenced
this pull request
Nov 20, 2023
## What Revert #83, which added connection options in a hardcoded way. <!-- Describe what changes are being made, e.g. which feature/bug is being developed/fixed in this PR? How did you verify the changes in this PR? --> ## Why With greenbone/openvas-scanner#1355 this options can be added when calling wmic or wmi via the library, and currently defaults to [sign]. This hardcoded options collide with the default or provided one. For testing: ``` wmic -d 7 -U domain/user%pass //192.168.0.1[sign,seal] "SELECT name FROM Win32_ComputerSystem" ``` or ``` `` <!-- Describe why are these changes necessary? --> ## References <!-- Add identifier for issue tickets, links to other PRs, etc. --> ## Checklist <!-- Remove this section if not applicable to your changes --> - [ ] Tests
|
Hello @ramijebara, Thanks a lot for your contribution. Unfortunately, I had to revert this PR, since it generate conflict with the existing way of adding options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added sign, seal to the bindstr variable, to samba/lib/com/dcom/main.c. Based on my experience, communication with newer versions of windows is much more reliable. queries that fail with the un-patched code work with this change.
Why
I was trying to communicate with fully patched Windows Server 2016+ machines and the default code was failing communication. After much research and testing of community suggestions I found that this change makes the communication much more reliable.
It has been tested for around 6 months.
References
This change was initially proposed in PR#81
jira issue reference: SC-953 // this line was added by ArnoStiefvater