Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paho-mqtt pypi package breaking changes #968

Closed
martinboller opened this issue Feb 12, 2024 · 2 comments · Fixed by #970
Closed

paho-mqtt pypi package breaking changes #968

martinboller opened this issue Feb 12, 2024 · 2 comments · Fixed by #970
Labels
bug Something isn't working

Comments

@martinboller
Copy link

Expected behavior

ospd-openvas should connect to MQTT creating MQTTClient using paho-mqtt.
Note version 1.6.1 still works, this only fails when upgrading to paho-mqtt 2.0.0

Actual behavior

with paho-mqtt version 2.0.0, producing the following error for both ospd-openvas and notus-scanner

Traceback (most recent call last):
File “/opt/gvm/gvmpy/lib/python3.11/site-packages/paho/mqtt/client.py”, line 874, in del
self._reset_sockets()
File “/opt/gvm/gvmpy/lib/python3.11/site-packages/paho/mqtt/client.py”, line 1133, in _reset_sockets
self._sock_close()
File “/opt/gvm/gvmpy/lib/python3.11/site-packages/paho/mqtt/client.py”, line 1119, in _sock_close
if not self._sock:
^^^^^^^^^^
AttributeError: ‘MQTTClient’ object has no attribute ‘_sock’

Steps to reproduce

install paho-mqtt version 2.0.0

Error with several different versions of ospd-openvas (tested latest and 2 previous releases)

@martinboller martinboller added the bug Something isn't working label Feb 12, 2024
@jjnicola
Copy link
Member

eclipse/paho.mqtt.python#814

@jjnicola
Copy link
Member

Hi @martinboller ,
Thanks for reporting this. Notus-scanner and ospd-openvas should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants