Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all ospd-openvas config files more consistent: #311

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Make all ospd-openvas config files more consistent: #311

merged 1 commit into from
Aug 10, 2020

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Aug 7, 2020

  • Don't use a DEBUG level in the example config file
  • Add various default and more sane config parameters
    to the environment file
  • Pass the arguments of the environment file to the systemd
    service

This has various reasons:

  1. We shouldn't tell the user to use /var/run/ospd/ospd.sock and/or /var/run/ospd.sock because there might be multiple OSPD scanners in the future
  2. Similar to 1. for /var/run/ospd.pid
  3. All other GVM components (gvmd, greenbone-nvt-sync) are expecting the feed-update.lock in <install-prefix>/var/run with GVM-20.08 (see Simplify sync lockfile handling gvmd#1059 and Use flock to lock the feed lock file. openvas-scanner#507) but the current default is /var/run/ospd

- Don't use a DEBUG level in the example config file
- Add various default and more sane config parameters
  to the environment file
- Pass the arguments of the environment file to the systemd
  service
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #311 into ospd-openvas-20.08 will decrease coverage by 0.82%.
The diff coverage is 51.02%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           ospd-openvas-20.08     #311      +/-   ##
======================================================
- Coverage               82.71%   81.89%   -0.83%     
======================================================
  Files                       9        9              
  Lines                    1481     1513      +32     
======================================================
+ Hits                     1225     1239      +14     
- Misses                    256      274      +18     
Impacted Files Coverage Δ
ospd_openvas/daemon.py 62.12% <35.00%> (-0.78%) ⬇️
ospd_openvas/preferencehandler.py 87.15% <50.00%> (+0.04%) ⬆️
ospd_openvas/db.py 96.24% <55.00%> (-3.36%) ⬇️
ospd_openvas/lock.py 85.96% <100.00%> (+0.25%) ⬆️
ospd_openvas/openvas.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9adb264...fce8a17. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we still should ship example like files or if we just should use concrete paths. Personally I am in favor of concrete paths.

@bjoernricks bjoernricks merged commit dda67e1 into greenbone:ospd-openvas-20.08 Aug 10, 2020
@cfi-gb cfi-gb deleted the ospd-openvas-sane-defaults branch August 10, 2020 06:29
@cfi-gb
Copy link
Member Author

cfi-gb commented Aug 10, 2020

The main problem i'm seeing is that we currently can't use something like cmake to configure / set the path during setup time like it is done when compiling other components.

ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants