Fix: queued scan count #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichtsfrei
reviewed
Feb 6, 2023
Avoid a race condition counting the amount of queued scans when many task are started at the same time. This bug leaded into wrong queue position number shown in the logs and could jump the max_queued_scans setting in some cases.
nichtsfrei
approved these changes
Feb 8, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
Wait 0, 10, 20, 30, ..., or 90 miliseconds when add a new scan in the queue. This try to avoid a race condition counting the amount of queued scans when many task are started at the same time. This leads into wrong queue position number shown in the logs and could jump the max_queued_scans setting in some cases. (cherry picked from commit fd35308) # Conflicts: # poetry.lock
jjnicola
added a commit
that referenced
this pull request
Feb 8, 2023
* Fix: queued scan count (#850) Wait 0, 10, 20, 30, ..., or 90 miliseconds when add a new scan in the queue. This try to avoid a race condition counting the amount of queued scans when many task are started at the same time. This leads into wrong queue position number shown in the logs and could jump the max_queued_scans setting in some cases. (cherry picked from commit fd35308) # Conflicts: # poetry.lock * Fix: issue with poetry.lock file --------- Co-authored-by: Juan José Nicola <juan.nicola@greenbone.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add lock for start_scan
Jira: SC-755
Why:
Avoid a race condition counting the amount of queued scans when many task
are started at the same time. This leads into wrong queue position
number shown in the logs and could jump the max_queued_scans setting
in some cases.
How:
start many task (25) at the same time and check the position in the queue. There should not be repeated position numbers for different tasks.
Checklist: