Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add OSP command get_vts. #12

Merged
merged 2 commits into from
Jun 8, 2018
Merged

Add OSP command get_vts. #12

merged 2 commits into from
Jun 8, 2018

Conversation

janowagner
Copy link
Member

This adds the command get_vts, for getting the list and details about
vulnerability tests a OSP scanner might offer.

So far, the tests have only an id and a name. It is intended
to extend this by some standard elements which are shared among
different scanners and with individual elements which are very specific
for a scanner.

With this status, it would be possible to have a client get the list and
allow the user to select one or many tests that are desired.

Follow-ups will be to add receive the vt selection from the client in
order to execute only these.

This change uses a simple dict for storage. With extending
capabilities, it might be helpful to use advanced containers/collections.

  • ospd/ospd.py: Add command get_vts and handling of data. Increase version
    of OSP to 1.2.

  • doc/OSP.xml: Add documentation for command get_vts.

This adds the command get_vts, for getting the list and details about
vulnerability tests a OSP scanner might offer.

So far, the tests have only an id and a name. It is intended
to extend this by some standard elements which are shared among
different scanners and with individual elements which are very specific
for a scanner.

With this status, it would be possible to have a client get the list and
allow the user to select one or many tests that are desired.

Follow-ups will be to add receive the vt selection from the client in
order to execute only these.

This change uses a simple dict for storage. With extending
capabilities, it might be helpful to use advanced containers/collections.

* ospd/ospd.py: Add command get_vts and handling of data.

* doc/OSP.xml: Add documentation for command get_vts.
@janowagner janowagner requested a review from a team June 6, 2018 13:24
@codecov
Copy link

codecov bot commented Jun 6, 2018

Codecov Report

Merging #12 into master will increase coverage by 1.03%.
The diff coverage is 82.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage    54.5%   55.54%   +1.03%     
==========================================
  Files           4        4              
  Lines         998     1037      +39     
==========================================
+ Hits          544      576      +32     
- Misses        454      461       +7
Impacted Files Coverage Δ
ospd/ospd.py 61.49% <82.5%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e994434...81a88d6. Read the comment docs.

* tests/testScanAndResult.py: Added 3 tests for get_vts command.
@jjnicola jjnicola merged commit 163f03e into greenbone:master Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants