This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Fix get_scanner_details(). #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the test with python3 -m setup.py tests, a test was failing while running with python3 -m unittest, it doesn't. The scanner_params variable was overwritten with the xml Element and passed dictionary was lost. A second issue was the et.Element type. isinstance() in xml.simple_response_str() does not recognize et.Element as Element, and therefore the parameter was not added to the final response. For this reason, Element is used in protocol instead of et.Element.
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 73.23% 73.52% +0.28%
==========================================
Files 18 18
Lines 2130 2130
==========================================
+ Hits 1560 1566 +6
+ Misses 570 564 -6
Continue to review full report at Codecov.
|
ArnoStiefvater
approved these changes
Feb 19, 2020
|
Sorry for breaking the scanner details. It seems for unknown reasons seems to be not the same as i''ve already observed this but did thought it was cause by something else. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the test with python3 -m setup.py tests, a test was failing
while running with python3 -m unittest, it doesn't.
The scanner_params variable was overwritten with the xml Element and
passed dictionary was lost.
A second issue was the et.Element type. isinstance() in xml.simple_response_str()
does not recognize et.Element as Element, and therefore the parameter was not added to the final
response. For this reason, Element is used in protocol instead of et.Element.