Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various CodeQL alerts #1104

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Fix various CodeQL alerts #1104

merged 5 commits into from
Dec 19, 2023

Commits on Dec 19, 2023

  1. Fix: Make explicit/implicit returns consistent 

    The check_command_status function will now always explicitly return
False unless the check succeeds while the non-None return from
_ssh_authentication_input_loop has been removed.
    @timopollmeier
    timopollmeier committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    28d75dd View commit details
    Browse the repository at this point in the history

  2. Fix: Remove unused variables for add_element returns 

    Some unused local variables holding the return values from add_element
calls are removed.
    @timopollmeier
    timopollmeier committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    fd3e3a2 View commit details
    Browse the repository at this point in the history

  3. Fix: Add InvalidArgumentType superclass init 

    The class InvalidArgumentType now explicitly calls the superclass
initializer, making it more explict that the message is set to None.
    @timopollmeier
    timopollmeier committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e5cebd5 View commit details
    Browse the repository at this point in the history

  4. Remove unreachable return 

    Co-authored-by: Björn Ricks <bjoern.ricks@greenbone.net>
    @timopollmeier @bjoernricks
    timopollmeier and bjoernricks authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    64d9c00 View commit details
    Browse the repository at this point in the history

  5. Fix formatting

    @timopollmeier
    timopollmeier committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    a024d3c View commit details
    Browse the repository at this point in the history