Connection #1117
Merged
Connection #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use composition instead of inheritance for reading xml data.
Improve GvmConnection by being just a protocol and not a specific implementation. This allows for more flexibility. For example the DebugConnection is now also a GvmConnection.
Conventional Commits Report
🚀 Conventional commits found. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
- Coverage 98.13% 97.93% -0.20%
==========================================
Files 60 60
Lines 4445 4461 +16
Branches 1060 1068 +8
==========================================
+ Hits 4362 4369 +7
- Misses 69 72 +3
- Partials 14 20 +6 ☔ View full report in Codecov by Sentry. |
y0urself
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactor Connection for better typing and improve class hierarchy
Why
Maintenance
Checklist