Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the details argument #290

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Changing the details argument #290

merged 2 commits into from
Sep 17, 2020

Conversation

y0urself
Copy link
Member

What:

Renaming the no_details argument to details to match all the other calls.

Why:

Uniform parameters are way better, also needed for the Backend.

How:

Checklist:

@y0urself y0urself requested a review from a team as a code owner September 17, 2020 11:11
@y0urself y0urself merged commit c8e02c5 into greenbone:master Sep 17, 2020
@y0urself y0urself deleted the rename-details-parameter branch January 10, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichtsfrei nichtsfrei nichtsfrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y0urself @nichtsfrei