Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl | bash #1

Open
shakna-israel opened this issue Sep 10, 2017 · 1 comment
Open

curl | bash #1

shakna-israel opened this issue Sep 10, 2017 · 1 comment

Comments

@shakna-israel
Copy link

curl -L https://git.io/fix-my-dns-plz | sudo bash

Please don't. This is not enough to be safe, secure or even free from corruption.

The same applies to https://github.com/greenboxal/dns-heaven/blob/0185735616db48003648c8466590f9ef5a837c94/install.sh#L8

Please at least verify the file is intact, or the request didn't 404.

set -e is not enough, in this case.

@greenboxal
Copy link
Owner

greenboxal commented Sep 12, 2017

Hey shakna, thanks for creating this issue and submitting your concerns. I'm aware of the security implications of that.

#2 suggested the use of homebrew which is a better way of installing software on macOS but I don't think I have time to fix this right now.

If you have the time, please, submit a pull request! I'd be very happy to merge it.

abscondment pushed a commit to abscondment/dns-heaven that referenced this issue Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants