Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nutraceuticals preprint to published version #23

Closed
wants to merge 3 commits into from

Conversation

rando2
Copy link
Contributor

@rando2 rando2 commented Aug 4, 2021

@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for greenelab-website ready!

🔨 Explore the source changes: e0dc808

🔍 Inspect the deploy log: https://app.netlify.com/sites/greenelab-website/deploys/610a993c48e06d0007b85d60

😎 Browse the preview: https://deploy-preview-23--greenelab-website.netlify.app

@rando2
Copy link
Contributor Author

rando2 commented Aug 4, 2021

@vincerubinetti I haven't had enough coffee yet so definitely possible I'm missing something, but I think there might be an error associated with the in-browser editing approach? The error message here is error: pathspec 'patch-1' did not match any file(s) known to git which I believe means it's failing to check out the branch these edits are on. I didn't deliberately switch to my fork or anything, just clicked the edit button on the markdown file. Figured I would ask in case you have any ideas!

@vincerubinetti
Copy link
Contributor

So you did this in the GitHub UI right:

image

I just made another PR with your same changes, and it created it on a branch rather than a fork for me. The only reason I can think of is because you didn't have permissions to create a branch? Like no write permissions...

I just checked the settings for this repo, and it doesn't look like any permissions were assigned... which is strange because people have definitely made changes before. Regardless, I just gave the entire greenelab write access to this repo, so maybe if you try again next time it will work.

Also, forks should still work with the auto-cite gh-actions, but the problem is you need to make the fork first, then enable gh-actions on it, then make the pull request. Have to do it in that order for it to work. And you can't do it in that order from the github web UI.

@vincerubinetti
Copy link
Contributor

#24

@rando2
Copy link
Contributor Author

rando2 commented Aug 4, 2021

Interesting! I believe that's what I did. Next time I can try doing it the non-lazy way and see if it works better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants