Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizer comparison on stratified cross-validation data #79

Merged
merged 16 commits into from
May 5, 2023

Conversation

jjc2718
Copy link
Member

@jjc2718 jjc2718 commented May 3, 2023

In order to separate the conclusion of the optimizer comparison into a separate small paper, we wanted to try it using stratified cross-validation (instead of holding out an entire cancer type or dataset); these changes enable that.

The results are mostly the same as we saw in #71: e.g. for KRAS:

image

And overall, liblinear performance is better than SGD for the best-performing model:

image

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jjc2718 jjc2718 requested a review from arielah May 3, 2023 14:52
Copy link

@arielah arielah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code all looks good, this analysis got pretty confusing in places so I recommended some spots for additional documentation for future readers.

@jjc2718 jjc2718 merged commit 002c9f4 into greenelab:master May 5, 2023
1 check passed
@jjc2718 jjc2718 deleted the stratified_optimizers branch May 5, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants