-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizer comparison on stratified cross-validation data #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
arielah
approved these changes
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code all looks good, this analysis got pretty confusing in places so I recommended some spots for additional documentation for future readers.
01_stratified_classification/nbconverted/lasso_range_all_optimizers.py
Outdated
Show resolved
Hide resolved
01_stratified_classification/nbconverted/lasso_range_gene_optimizers.py
Outdated
Show resolved
Hide resolved
01_stratified_classification/scripts/run_lasso_compare_vogelstein.sbatch
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to separate the conclusion of the optimizer comparison into a separate small paper, we wanted to try it using stratified cross-validation (instead of holding out an entire cancer type or dataset); these changes enable that.
The results are mostly the same as we saw in #71: e.g. for KRAS:
And overall, liblinear performance is better than SGD for the best-performing model: