Update sparsity figure + regenerate figshare data #84
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jjc2718
requested review from
arielah and
nrosed
and removed request for
arielah
|
View / edit / reply to this conversation on ReviewNB nrosed commented on 2023-06-20T19:44:12Z Line #14. all_nz_coefs_df = all_nz_coefs_df[all_nz_coefs_df.lasso_param != 3.16e-08] its not immediately obvious to me where the 3.16e-08 number comes from, maybe useful to add a comment |
|
View / edit / reply to this conversation on ReviewNB nrosed commented on 2023-06-20T19:44:13Z Line #41. color_boxes(plt.gca()) pretty plot! |
|
View / edit / reply to this conversation on ReviewNB nrosed commented on 2023-06-20T19:44:14Z I am guessing the lines are plotted over one another is there a way you could make the points have different shapes so you could see the points overlapping? jjc2718 commented on 2023-06-26T15:15:46Z Varying the line styles seems to show the overlap a bit more clearly:
|
| @@ -23,7 +23,8 @@ for gene in "${genes[@]}"; do | |||
| cmd="papermill lasso_range_gene_optimizers.ipynb " | |||
There was a problem hiding this comment.
I did not know papermill existed! very cool!
|
Varying the line styles seems to show the overlap a bit more clearly:
View entire conversation on ReviewNB |
Small changes to one of the supplementary figures, before generating supplementary data for all the genes to include with our paper. Not too many extensive code changes here.