-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PDF format figures #28
Conversation
Nice! What method did you use to create the eps files? Things look good except for any elements involving transparency. For example, a screenshot of Notice how the points, which have transparency, have been rasterized. Apparently, there might be an R From the stack:
For connectivity search, we had some luck first creating a PDF and then running So if not too much of a pain, I think we should export to PDF. And then we can see if we can get emulated vector transparency via a different program for converting PDF to EPS. I'll comment on individual files if things already look good. |
img/feature-auroc.eps
Outdated
/g 37 def | ||
/p 38 def | ||
end readonly def | ||
/sfnts [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For img/feature-auroc.eps
, it might be easiest to just remove transparency from points altogether. Their fill can be adjusted to keep the same colors if desired. There's a single overplotting, but we'd still see some of the background point. Dashed vline should go behind points if easy.
img/percent_swapped.eps
Outdated
@@ -0,0 +1,1067 @@ | |||
%!PS-Adobe-3.0 EPSF-3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this figure in supplement, so EPS likely not needed, but also it looks totally good... no transparency
img/hetionet_degrees.eps
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hetionet_degrees.eps
looks good as is
Exactly! I just modified the extension in each file name. Regarding Gigascience, is there a reason we prefer EPS over PDF for vector graphics? It seems like Gigascience prefers PDF. |
Ah wow the instructions to authors does say:
Submitting PDFs would be infinitely better and easier than EPS files! But now I'm sort of confused why Gigascience/Aptara requesed EPS files for connectivity search in order to create vectors instead of PDF. So let's try PDF and see what happens. |
Ok! I'll push one more commit that just puts all the figures into PDF format then. |
References this discussion in greenelab/xswap-manuscript#69.