Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplemental information #74

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

zietzm
Copy link
Collaborator

@zietzm zietzm commented Dec 28, 2023

This builds a standalone PDF locally using build.sh. I'm not sure how to make this be built using CI here, or if we want that. I can push a PDF of the supplement if desired.

References #69

\begin{equation}
P_{i,j} = \frac{d(u_i) d(v_j)}{\sqrt{(d(u_i) d(v_j))^2 + (m - d(u_i) - d(v_j) + 1)^2}}
\end{equation}
$$P_{i,j} = \frac{d(u_i) d(v_j)}{\sqrt{(d(u_i) d(v_j))^2 + (m - d(u_i) - d(v_j) + 1)^2}}$$
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, but the previous version rendered the equation in red on my machine. Going to $$ fixes this.

@dhimmel
Copy link
Collaborator

dhimmel commented Dec 29, 2023

This build a standalone PDF locally using build.sh. I'm not sure how to make this be built using CI here

We should be able to get the desired effect with a workflow dispatch / adhoc CI job here. I'll configure like the following:

image

Running in this job... will update comment with outputs uploaded as artifact.

manuscript-7357539602-55ccf90.zip

Hmm, the build ended up building the main branch and not supplement. Let me look into why

@dhimmel
Copy link
Collaborator

dhimmel commented Dec 29, 2023

Let me look into why

Ah, that's because the supplement branch in the greenelab repo doesn't have the PR commit yet. I will merge this PR, and then we can make subsequent commits to the supplement branch in greenelab/xswap-manuscript

Post-merge running job:
manuscript-7357607789-303d5a5.zip

PDF looks good. I'll play around with 2 small updates:

  • adding the article title somehow
  • seeing if we can prefix figure and table numbers with S

@dhimmel dhimmel merged commit 303d5a5 into greenelab:supplement Dec 29, 2023
@zietzm zietzm deleted the supplement branch December 29, 2023 15:27
@dhimmel
Copy link
Collaborator

dhimmel commented Dec 29, 2023

Made some tweaks in 99b1ad9, ran a dispatch, and uploading manuscript-7357911735-99b1ad9.zip. Extracted PDF: 2023-12-29_xswap-supplementary-information.pdf

dhimmel added a commit that referenced this pull request Feb 7, 2024
match the gigascience publication numbering to avoid confusion

refs #74
dhimmel added a commit that referenced this pull request Feb 7, 2024
match the gigascience publication numbering to avoid confusion

refs #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants