Unit Test and Bug Fix for Issue 4 #14
Conversation
Set Javamail dependency version to 1.5.2 - latest version of Javamail as of 10/2014.
…e constructed emails to be sent through GreenMail Added a test to GreenMailUtilTest to verify a bad envelope being generated when IMAP messages with message-id's that have unescaped characters are fetched. See #4 for more details.
…eld of a fetched email prior to it being added to a mail enevelope. Added dependency on Apache Commons Lang to use a helper/utility class that escapes Java strings
buildscientist
changed the title
buildscientist
changed the title
…nt originally set and found in the retrieved email
| <version>1.4.7</version> | ||
| <groupId>com.sun.mail</groupId> | ||
| <artifactId>javax.mail</artifactId> | ||
| <version>1.5.2</version> |
There was a problem hiding this comment.
Please remove the version here, it's already defined in the parent pom
There was a problem hiding this comment.
Sorry I'm a little confused - isn't this POM the parent? This is the one at the root of the project.
|
This time there are much less changes, that's good. Sadly we still have a lot of "phantom" changes (whitespace changes) that result form code formatter differences. We should have some code formatting guidelines.Eclipse can export the code formatter settings so that would be a solution. |
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| <exclusions> |
There was a problem hiding this comment.
I'll remove this exclusion from here as it's already being defined in the parent POM.
| @@ -363,6 +364,7 @@ String parseEnvelope() { | |||
| } | |||
| response.add(SP); | |||
| if (messageID != null && messageID.length > 0) { | |||
| messageID[0] = StringEscapeUtils.escapeJava(messageID[0]); | |||
There was a problem hiding this comment.
If you comment this line out and run the unit test here the test will fail.
|
I'll make an effort not to format the entire file when making changes. Sorry - bad habit I suppose. I appreciate your patient with all this. |
|
No problem :-) . Thanks for your pull request. |
Unit Test and Bug Fix for Issue 4
Submitting a PR containing the following changes: