Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-7527 Move blocks report into master theme #2303

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sagarsdeshmukh
Copy link
Member

@sagarsdeshmukh sagarsdeshmukh commented Jun 4, 2024

Ref. https://jira.greenpeace.org/browse/PLANET-7527

Requirements

Migrate Blocks Report code to master theme.
That should also include classic blocks report functionality.
Verify that the API endpoints also work with the plugin de-activated.

The following folder name is changed during the migration to the master theme:
classes/search => src/BlockReportSearch

Testing:

  • You can test this PR along with blocks repo PR on Local environment or on test-venus test instance
  • De-activate the Blocks plugin, and check all blocks reports, It should work as expected The blocks report functionality should work as as expected
  • The Plugins blocks report API should work as expected.

@sagarsdeshmukh sagarsdeshmukh self-assigned this Jun 4, 2024
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 4, 2024
/unhold a3f08390-c0ea-4d9d-acfc-fc87b67d8ad3
@planet-4
Copy link
Contributor

planet-4 commented Jun 4, 2024

Test instance is ready 🚀

🌑 venus | admin | blocks report | CircleCI | composer-local.json

⌚ 2024.07.11 04:25:23

planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 4, 2024
/unhold ee351bad-435b-4505-b140-69ef019468b2
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 4, 2024
/unhold 7e87a10b-7c89-47cc-86ee-3afdc6fc6ca4
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 5, 2024
/unhold 67080fdd-b782-41e6-89df-7feebe034c60
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 5, 2024
/unhold d59731a1-229b-458c-be04-8aae142cdbbd
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 5, 2024
/unhold 1a07c6bd-76d2-4981-8049-0d5f472f950c
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 5, 2024
/unhold 0086272d-9270-4892-906e-2c307e333935
@sagarsdeshmukh sagarsdeshmukh requested review from a team, mleray, GP-Dan-Tovbein and Osong-Michael and removed request for a team and GP-Dan-Tovbein June 5, 2024 11:36
@sagarsdeshmukh sagarsdeshmukh marked this pull request as ready for review June 5, 2024 11:37
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 14, 2024
/unhold 4b5e5741-f302-4ebb-8b4a-f9392b93ea93
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 19, 2024
/unhold 5b7857bd-9965-4f3a-988d-70fcaee50bbd
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 19, 2024
/unhold 33820087-9daf-4a72-9ef3-ffff33c945f1
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jun 28, 2024
/unhold df9335af-abd5-4f23-b6a5-32e12fa2559a
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jul 1, 2024
/unhold 3620b3fa-f3ed-42f8-a5a6-9a1352519dc5
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jul 1, 2024
/unhold 97141e6d-32bf-4ece-b834-f46293b5224d
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jul 1, 2024
/unhold 43bbaa74-6394-41a4-9d10-a924d743758e
Copy link
Contributor

@Osong-Michael Osong-Michael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sagarsdeshmukh testing this locally we don't seem to have the report for planet4-block-templates, was that intentional, because with the old implementation we had that report?

Screenshot 2024-07-03 at 11 25 43

@sagarsdeshmukh
Copy link
Member Author

PLANET-7527 Remove blocks report functionality from blocks plugin greenpeace/planet4-plugin-gutenberg-blocks#1215

Good catch 👍 , It should show block templates as well.

planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jul 5, 2024
/unhold 6a31cf7e-35d1-49e8-a438-81a163449279
planet-4 added a commit to greenpeace/planet4-test-sinope that referenced this pull request Jul 5, 2024
/unhold 670b2ee0-093d-450e-aa2b-821e6a5cf385
planet-4 added a commit to greenpeace/planet4-test-venus that referenced this pull request Jul 9, 2024
/unhold 49f7f2ad-ce21-4941-9b82-07a4692a7bdb
planet-4 added a commit to greenpeace/planet4-test-venus that referenced this pull request Jul 11, 2024
/unhold 60a598ad-23ca-44bb-b921-46527ced12c6
@sagarsdeshmukh
Copy link
Member Author

Hey @sagarsdeshmukh testing this locally we don't seem to have the report for planet4-block-templates, was that intentional, because with the old implementation we had that report?

Screenshot 2024-07-03 at 11 25 43

Hi @Osong-Michael , Could you please check now?

@Osong-Michael
Copy link
Contributor

Osong-Michael commented Jul 11, 2024

Hey @sagarsdeshmukh testing this locally we don't seem to have the report for planet4-block-templates, was that intentional, because with the old implementation we had that report?
Screenshot 2024-07-03 at 11 25 43

Hi @Osong-Michael , Could you please check now?

Hey Sagar, just tested now. Still no planet4-block-templates in the report and also something weird on the test-instance. It does not seem to filter by block name

Screenshot 2024-07-11 at 09 54 53 Screenshot 2024-07-11 at 09 56 04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants