PLANET-7561 Remove Blank Page pattern #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We move it to the master theme
mleray
force-pushed
the
remove-blank-page-pattern
branch
from
ffca600
to
27b472e
Compare
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 1, 2024
/unhold 7d9af71d-bd07-4bf8-bdb7-40e3763c7f5f
mleray
commented
Jul 1, 2024
| @@ -77,12 +76,9 @@ private function fetch_items(): void { | |||
| * Get all patterns names | |||
| */ | |||
| private function pattern_names(): array { | |||
| return array_filter( | |||
There was a problem hiding this comment.
I wasn't sure how to solve this issue, but I figured this was an OK fix for now since we already have an open PR to move this report to the theme, which will need to be updated anyways
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 1, 2024
/unhold 9e8d7d64-059f-4810-b90d-43b4bcc9a2b9
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 1, 2024
/unhold 4b2d5c84-7ac4-499f-a4a7-72b32f41d0b9
Test instance is ready 🚀🌑 umbriel | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.07.01 10:42:51 |
comzeradd
approved these changes
Jul 1, 2024
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 1, 2024
/unhold 0205abd6-0ee5-483c-8fed-ce0d0a28b75d
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 1, 2024
/unhold 0d7e79c1-bbab-44a3-9a45-474f58ea22ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See PLANET-7561
We move it to the master theme instead, see related PR
Testing
Either on local or on the umbriel test instance, you should be able to add a Blank Page pattern just like before.