PLANET-7365: Clean up Listing page code #2310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecesary code
GP-Dan-Tovbein
force-pushed
the
PLANET-7365_cleanup-listing-pages-codebase
branch
from
93b8ea6
to
c10af5b
Compare
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Jun 14, 2024
/unhold 69941b81-9b00-4862-a599-0e4d3d2db1d7
Test instance is ready 🚀🌑 oberon | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.06.25 09:34:17 |
- Fix sonar cloud
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Jun 17, 2024
/unhold f5fa74fd-1657-4c28-809a-f608af3c86f3
GP-Dan-Tovbein
commented
Jun 17, 2024
| @@ -34,14 +34,7 @@ | |||
| 'width' => '300', | |||
| 'height' => '300', | |||
| ]; | |||
|
|
|||
There was a problem hiding this comment.
Noticing that this value is not being used by us, only by a couple of NROs. Do we really need to add it? What if we ask them to include into their themes instead?
https://github.com/search?q=org%3Agreenpeace%20author_share_buttons&type=code
There was a problem hiding this comment.
I think @comzeradd would know better about this, especially if we need to warn the NROs about the change!
- Clean up
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Jun 17, 2024
/unhold 735b6d81-37eb-4723-9cbc-fd5426f43ae2
mleray
reviewed
Jun 25, 2024
| @@ -24,6 +24,7 @@ | |||
| type="button" | |||
| data-bs-toggle="collapse" | |||
| data-bs-target="#menu-{{ targetId }}" | |||
| aria-label="Nav Link Button" | |||
There was a problem hiding this comment.
This should be translatable
planet-4
added a commit
to greenpeace/planet4-test-oberon
that referenced
this pull request
Jun 25, 2024
/unhold a14c00c0-ad5c-4e0b-8493-c62fc6eda8ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://jira.greenpeace.org/browse/PLANET-7365
Description
Remove duplicated, unused and obsolete code related to listing pages