Fixes to tc_hmis loaders #4123
Merged
Fixes to tc_hmis loaders #4123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigxz
commented
Mar 14, 2024
| @@ -69,6 +69,7 @@ def perform | |||
| ) | |||
| end | |||
|
|
|||
| # FIXME: cell phones being imported as float strings, eg "1112223333.0" unable to reproduce locally | |||
There was a problem hiding this comment.
@ttoomey this is so odd! I re-ran it again in production, from the exact same excel file, and I see the numbers being stored correctly. I guess I'll remove this comment and hope for the best- (i.e. make sure to check them every time...).
There was a problem hiding this comment.
And for reference, roo-rb/roo#53
eanders
added a commit
that referenced
this pull request
Mar 28, 2024
* Require that client alert expiration date be in the future (#4073) Co-authored-by: Gig <gig@greenriver.org> * Label custom assessments in audit events (#4063) * Label custom assessments in audit events * Add test to assessment name audit * Avoid n+1 issue when loading custom assessment title Co-authored-by: Theron Toomey <ttoomey@greenriver.org> * Use changed_record instead of object for ar assoc * Use customassesment instead of changed_record --------- Co-authored-by: Theron Toomey <ttoomey@greenriver.org> Co-authored-by: Gig <gig@greenriver.org> * TC Custom Service Importer (#4035) includes sleep for test failure, not sure what's going on with that Co-authored-by: Theron Toomey <ttoomey@greenriver.org> Co-authored-by: Gig <gig@greenriver.org> * 187134062 link ce records to dcs and hat loaders (#4092) Co-authored-by: Gig <gig@greenriver.org> * Clean up undefined variable in JS for performance dashboard horizontal bar truncation. THis was causing the bar charts to fail to display. (#4096) * Update destinations report to include Personal ID in the client data web and excel report (#4097) * Update destinations report to include Personal ID in the client data web and excel report * Pull the PersonalID from the exit table instead of the Client table * Port table behavior from other reports --------- Co-authored-by: Elliot Anders <elliot@greenriver.org> * Catch error in FetchClientsWithActiveReferralsJob (#4107) * Bulk services changes for Bed Night, support searching by household:id (#4087) * Make Form Definitions paranoid, restrict deleting them (#4109) * Add paper trail and restrictions to form definition * Add paper trail and restrictions to form definition * Add test case with commentcgst * Add Scan Card Loader (#4108) * More test cases for assessment deletion (#4113) * Add permission caching that fixes bug with project deletion (#4110) * update check for spm reporting and comparison ids to find report client with existing id (#4115) * Only send telehealth POS codes when the member is reached * 187118505 tc data importer qa (#4101) * add meal service importer * extrapolate missing enrollment identifiers for services * adjust custom assessment importers to find-or-create form definitions * match form definition identifiers to what's defined on staging * fix missing parse_duration that got lost in the last merge * normalize all uuids to correct format * correct fields on case management assessment loader, critical document loader * adjust custom service loader to be safer when clobbering old data with multi-part imports * adjust custom service loader "substance abuse" services * remove unused EHV importer * correct col names in MHMR imports * add rake task to collect quick stats on hud tables as a proof against accidental changes * service naming adjustment #187215113 --------- Co-authored-by: Gig Ashton <gig@greenriver.org> * Bugfix in MigrateAssessmentsJob for generating empty intakes; performance improvement (#4114) * Util to set all enrollment cocs (#4112) * Update some cded keys in loaders (#4117) * Ungroup ES Entry/Exit and NBN so they show up separately in the system pathways report. (#4111) Co-authored-by: Elliot <elliot@greenriver.org> * Limit household calculations to CoCs as appropriate (#4124) * Only resolve CustomDataElements that exist (#4086) * Generate another project summary file (#4122) * Generate another project summary file * Include organization name * HMIS configuration migration util class (#4119) * Util for reading and writing HMIS Configuration * Update comments * Patch flaky test date (#4125) * Aw/hic pit 185769387 (#3993) * WIP: 2024 PIT * WIP: 2024 HIC * Apply changes from merge conflict. * Update warehouse schema. * return the filter in lsa_filter update method instead of the end date * 2024 pit questions * Update queston names and minor code cleanup * 2024 version of DomesticViolenceSurvivor * Use more understandable language --------- Co-authored-by: Dave G <dgreiner@greenriver.org> Co-authored-by: Elliot Anders <elliot@greenriver.org> * Fixes to tc_hmis loaders (#4123) * Fixes to tc_hmis loaders * Remove comment * Fix substance use config (#4130) * Fix substance use config * gig/service-loader-patch * log missed services * remove unused meal services --------- Co-authored-by: Theron Toomey <ttoomey@greenriver.org> * System Pathways Chronic Bug (#4127) * bug fix for report checking for chronic at entry when chronic_member variable is false * Update drivers/system_pathways/app/models/system_pathways/report.rb Co-authored-by: Elliot <elliot@greenriver.org> --------- Co-authored-by: Elliot <elliot@greenriver.org> * Additional queries and filters to support service/form config tools (#4102) * Rescue missing source data on account downloads page (#4133) * All Neighbors System Dashboard CE adjustments (#4058) * Use destination client ids when looking for ce events * Preload for faster calculation * Catch missing client info * Rake task for generating CustomDataElementDefinitions (#4103) * Add back accepts_nested_attributes_for with reg test (#4137) * Some proposed changes given the worst performing queries found in the (#4140) health database, including some guesses based on what I think was causing the database to crash. agency/team performance breaks the query that I think was killing the server into chunks that take about 15 seconds each. * Service loader improvements (#4142) * Exporter incorrectly detecting override to PH (#4145) * Hotfix for the exporter incorrectly determining that something was overridden * Adjust test that should have caught this * PIT - reorder multiracial and update 65+ text (#4148) * Disable dashboard claims data (#4146) * Disable and hide well care visit columns and calculations * Disable and hide claims reporting patient dashboard data * Local funder rule patches (#4144) * Add project services spec (#4150) * Service loader naming fix (#4149) * Fix bug in assessment eligibility logic (#4147) * Local funder rule patches * Fix HoH and Adults logic * Add comment * Default to 99 for vsp value (#4155) * 187277049-generate_missing_ce_assessments_for_dce (#4161) * CoC and date range enforcement (#4187) * Limit the projects that are actually included in HUD reports to those that include enrollments that overlap the date range AND are in the chosen CoCs despite what is chosen in the form; initially just for the LSA * Include any projects that are open during the range * Limit all LSA project IDs to those that were active during the relevant range; expand the range to the look-back stop date * Centralize LSA date range calculation, special case HIC * Update app/models/filters/hud_filter_base.rb Co-authored-by: Gig <gig@greenriver.org> * Cache based on date range; add a test for new effective in date range method --------- Co-authored-by: Gig <gig@greenriver.org> --------- Co-authored-by: martha <medwards@greenriver.org> Co-authored-by: Gig <gig@greenriver.org> Co-authored-by: Theron Toomey <ttoomey@greenriver.org> Co-authored-by: Sandy Wise <33072305+awisema@users.noreply.github.com> Co-authored-by: Dave G <149399758+dtgreiner@users.noreply.github.com> Co-authored-by: Sandy Wise <sandy@greenriver.org> Co-authored-by: Dave G <dgreiner@greenriver.org> Co-authored-by: Todd <tdblackman@gmail.com>
dtgreiner
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Fixes to tc_hmis loaders * Remove comment
dtgreiner
added a commit
that referenced
this pull request
Apr 19, 2024
* Require that client alert expiration date be in the future (#4073) Co-authored-by: Gig <gig@greenriver.org> * Label custom assessments in audit events (#4063) * Label custom assessments in audit events * Add test to assessment name audit * Avoid n+1 issue when loading custom assessment title Co-authored-by: Theron Toomey <ttoomey@greenriver.org> * Use changed_record instead of object for ar assoc * Use customassesment instead of changed_record --------- Co-authored-by: Theron Toomey <ttoomey@greenriver.org> Co-authored-by: Gig <gig@greenriver.org> * TC Custom Service Importer (#4035) includes sleep for test failure, not sure what's going on with that Co-authored-by: Theron Toomey <ttoomey@greenriver.org> Co-authored-by: Gig <gig@greenriver.org> * 187134062 link ce records to dcs and hat loaders (#4092) Co-authored-by: Gig <gig@greenriver.org> * Clean up undefined variable in JS for performance dashboard horizontal bar truncation. THis was causing the bar charts to fail to display. (#4096) * Update destinations report to include Personal ID in the client data web and excel report (#4097) * Update destinations report to include Personal ID in the client data web and excel report * Pull the PersonalID from the exit table instead of the Client table * Port table behavior from other reports --------- Co-authored-by: Elliot Anders <elliot@greenriver.org> * Catch error in FetchClientsWithActiveReferralsJob (#4107) * Bulk services changes for Bed Night, support searching by household:id (#4087) * Make Form Definitions paranoid, restrict deleting them (#4109) * Add paper trail and restrictions to form definition * Add paper trail and restrictions to form definition * Add test case with commentcgst * Add Scan Card Loader (#4108) * More test cases for assessment deletion (#4113) * Add permission caching that fixes bug with project deletion (#4110) * update check for spm reporting and comparison ids to find report client with existing id (#4115) * Only send telehealth POS codes when the member is reached * 187118505 tc data importer qa (#4101) * add meal service importer * extrapolate missing enrollment identifiers for services * adjust custom assessment importers to find-or-create form definitions * match form definition identifiers to what's defined on staging * fix missing parse_duration that got lost in the last merge * normalize all uuids to correct format * correct fields on case management assessment loader, critical document loader * adjust custom service loader to be safer when clobbering old data with multi-part imports * adjust custom service loader "substance abuse" services * remove unused EHV importer * correct col names in MHMR imports * add rake task to collect quick stats on hud tables as a proof against accidental changes * service naming adjustment #187215113 --------- Co-authored-by: Gig Ashton <gig@greenriver.org> * Bugfix in MigrateAssessmentsJob for generating empty intakes; performance improvement (#4114) * Util to set all enrollment cocs (#4112) * Update some cded keys in loaders (#4117) * Ungroup ES Entry/Exit and NBN so they show up separately in the system pathways report. (#4111) Co-authored-by: Elliot <elliot@greenriver.org> * Limit household calculations to CoCs as appropriate (#4124) * Only resolve CustomDataElements that exist (#4086) * Generate another project summary file (#4122) * Generate another project summary file * Include organization name * HMIS configuration migration util class (#4119) * Util for reading and writing HMIS Configuration * Update comments * Patch flaky test date (#4125) * Aw/hic pit 185769387 (#3993) * WIP: 2024 PIT * WIP: 2024 HIC * Apply changes from merge conflict. * Update warehouse schema. * return the filter in lsa_filter update method instead of the end date * 2024 pit questions * Update queston names and minor code cleanup * 2024 version of DomesticViolenceSurvivor * Use more understandable language --------- Co-authored-by: Dave G <dgreiner@greenriver.org> Co-authored-by: Elliot Anders <elliot@greenriver.org> * Fixes to tc_hmis loaders (#4123) * Fixes to tc_hmis loaders * Remove comment * Fix substance use config (#4130) * Fix substance use config * gig/service-loader-patch * log missed services * remove unused meal services --------- Co-authored-by: Theron Toomey <ttoomey@greenriver.org> * System Pathways Chronic Bug (#4127) * bug fix for report checking for chronic at entry when chronic_member variable is false * Update drivers/system_pathways/app/models/system_pathways/report.rb Co-authored-by: Elliot <elliot@greenriver.org> --------- Co-authored-by: Elliot <elliot@greenriver.org> * Additional queries and filters to support service/form config tools (#4102) * Rescue missing source data on account downloads page (#4133) * All Neighbors System Dashboard CE adjustments (#4058) * Use destination client ids when looking for ce events * Preload for faster calculation * Catch missing client info * Rake task for generating CustomDataElementDefinitions (#4103) * Add back accepts_nested_attributes_for with reg test (#4137) * Some proposed changes given the worst performing queries found in the (#4140) health database, including some guesses based on what I think was causing the database to crash. agency/team performance breaks the query that I think was killing the server into chunks that take about 15 seconds each. * Service loader improvements (#4142) * Exporter incorrectly detecting override to PH (#4145) * Hotfix for the exporter incorrectly determining that something was overridden * Adjust test that should have caught this * PIT - reorder multiracial and update 65+ text (#4148) * Disable dashboard claims data (#4146) * Disable and hide well care visit columns and calculations * Disable and hide claims reporting patient dashboard data * Local funder rule patches (#4144) * Add project services spec (#4150) * Service loader naming fix (#4149) * Fix bug in assessment eligibility logic (#4147) * Local funder rule patches * Fix HoH and Adults logic * Add comment * Default to 99 for vsp value (#4155) * 187277049-generate_missing_ce_assessments_for_dce (#4161) * CoC and date range enforcement (#4187) * Limit the projects that are actually included in HUD reports to those that include enrollments that overlap the date range AND are in the chosen CoCs despite what is chosen in the form; initially just for the LSA * Include any projects that are open during the range * Limit all LSA project IDs to those that were active during the relevant range; expand the range to the look-back stop date * Centralize LSA date range calculation, special case HIC * Update app/models/filters/hud_filter_base.rb Co-authored-by: Gig <gig@greenriver.org> * Cache based on date range; add a test for new effective in date range method --------- Co-authored-by: Gig <gig@greenriver.org> --------- Co-authored-by: martha <medwards@greenriver.org> Co-authored-by: Gig <gig@greenriver.org> Co-authored-by: Theron Toomey <ttoomey@greenriver.org> Co-authored-by: Sandy Wise <33072305+awisema@users.noreply.github.com> Co-authored-by: Dave G <149399758+dtgreiner@users.noreply.github.com> Co-authored-by: Sandy Wise <sandy@greenriver.org> Co-authored-by: Dave G <dgreiner@greenriver.org> Co-authored-by: Todd <tdblackman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please squash merge this PR
Description
Minor fixes to loaders
Type of change
Checklist before requesting review