Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SQL Delight 0.4.4 #17

Closed
JakeWharton opened this issue Aug 4, 2016 · 4 comments
Closed

Update to SQL Delight 0.4.4 #17

JakeWharton opened this issue Aug 4, 2016 · 4 comments
Assignees

Comments

@JakeWharton
Copy link

JakeWharton commented Aug 4, 2016

We added native support for short because we saw you were trying to use them (aside: dear god why shorts????). The docs never should have said short was supported because literally 0 people should be using it (hence why we didn't support it).

@greenrobot-team
Copy link
Collaborator

I assume it's a leftover from a long time ago, not sure. @greenrobot any reasons why the perf test includes short, can we remove it? -ut

@greenrobot-team greenrobot-team self-assigned this Aug 8, 2016
@greenrobot
Copy link
Owner

The idea just was to cover basic types. I'd like to keep the testing scenario the same - we used it for years and this way it stays stable.

@greenrobot
Copy link
Owner

P.S. @JakeWharton: Did it have any effect? Would be surprised if this makes any difference, SQLite doesn't care anyway.

@JakeWharton
Copy link
Author

It'll avoid boxing through your custom ColumnAdapter so you get less
garbage on the heap and less GC pressure.

On Mon, Aug 8, 2016, 3:14 AM greenrobot notifications@github.com wrote:

P.S. @JakeWharton https://github.com/JakeWharton: Did it have any
effect? Would be surprised if this makes any difference, SQLite doesn't
care anyway.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#17 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEVcNY3YUrZq0AflzCw8h6KfeS-qnks5qdtc7gaJpZM4Jc56s
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants