Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wheel instead of mousewheel #434

Closed
karlcow opened this issue Feb 16, 2021 · 4 comments
Closed

Use wheel instead of mousewheel #434

karlcow opened this issue Feb 16, 2021 · 4 comments

Comments

@karlcow
Copy link

karlcow commented Feb 16, 2021

mousewheel is deprecated. This creates breakage in Firefox.

wheel events are supported everywhere.

@jackdoyle
Copy link
Member

No problem - I can make that change in the next release. Thanks for pointing it out.

@karlcow
Copy link
Author

karlcow commented Feb 17, 2021

@jackdoyle note that I created a pull request for it.
Tell me if there is something missing for you, I can adjust
#435

@jackdoyle
Copy link
Member

Thanks! We don't accept pull requests, but I've already got the changes made in the upcoming release, so we should be all set.

jackdoyle added a commit that referenced this issue Mar 25, 2021
- NEW: you can define onStart, onComplete, and onInterrupt callbacks in the snap:{} object of a ScrollTrigger to sense when snapping starts, completes or gets interrupted. See https://greensock.com/forums/topic/27305-scrolltrigger-feature-request-onsnapinterrupt-callback/

- NEW: you can prevent ScrollTrigger from factoring inertia into snapping by passing in inertia: false via a snap object, like snap: {snapTo: "labels", inertia: false, duration: 0.5}

- NEW: MorphSVGPlugin.normalizeStrings() method that lets you feed in two path data strings and it'll return an Array with normalized strings that contain the same number of points.

- NEW: you can append "nowrap" to a drawSVG value to prevent the stroke from wrapping/looping, like drawSVG: "80% 120% nowrap".

- NEW: added a LottieScrollTrigger helper function to the docs: https://greensock.com/docs/v3/HelperFunctions#lottie

- IMPROVED: removed pixel snapping in ScrollToPlugin because most browsers support sub-pixel scroll values now.

- IMPROVED: when you kill() a tween/timeline that's attached to a ScrollTrigger, it will also kill that ScrollTrigger.

- FIXED: if a zIndex is set on a Flip.from() call, it may take 1 tick before being applied (unless you set immediateRender: true). Now setting a zIndex will automatically make the animation default to immediateRender: true.

- FIXED: TypeScript improvement for PixiPlugin to accommodate string-based (relative) values for x, y, and a few others. See #430

- FIXED: regression in 3.5.0 caused ScrollToPlugin's onAutoKill callback not to get triggered properly. See https://greensock.com/forums/topic/26840-scrolltoplugin-onautokill-callback-not-firing-timeline-issues/

- FIXED: if you animate a path that has vector-effect="non-scaling-stroke", it could throw an error. See https://greensock.com/forums/topic/26915-drawsvg-console-error-with-non-scaling-strokes/

- FIXED: in certain rare cases, setting the playhead of a repeating timeline to a value that crosses the repeat boundary backwards (spanning iterations), it could render at the start incorrectly.

- FIXED: if you attempt to use Draggable on a shadow dom element, it could throw an error (regression in 3.6.0). See #431

- FIXED: onStart fired on zero-duration tweens/timelines even though it shouldn't (onStart is for when the playhead moves from the 0 position). Related to #419

- FIXED: if you had default units for x, y, width, or height set to something other than "px", it could affect Flip. See https://greensock.com/forums/topic/26977-flip-conflicting-with-altering-units-in-config/

- FIXED: a regression in 3.6.0 could cause problems when animating a CSS variable that's a color.

- FIXED: when plotting global coordinates of a root <svg> element (which could happen in Flip or MotionPathPlugin or Draggable), if the contents of that <svg> are scaled it could offset things incorrectly. See https://greensock.com/forums/topic/27152-flipping-svgs/

- FIXED: if an animation is killed from within its onRepeat callback, it could render slightly past where it should. See https://greensock.com/forums/topic/27176-gsap-3-tween-a-timeline-object/

- FIXED: changed "mousewheel" event listening to "wheel" in ScrollTrigger for better compatibility. See #434

- FIXED: if you used a ScrollTrigger snap of "labelsDirectional", in rare situations it might snap again after the initial snap, going to the next label, then the next.

- FIXED: in an extremely uncommon scenario, a ScrollTrigger that's supposed to snap might not snap if you scroll very slowly and interrupt the snap.

- FIXED: regression in 3.6.0 caused timeline.tweenTo()/tweenFromTo(), to ignore an ease defined in the vars (it always used ease: "none"). See https://greensock.com/forums/topic/27351-tweento-ease-not-working/

- FIXED: if you set a "transform" value to a matrix() on an SVG element, it could be decomposed incorrectly in certain scenarios. This could, in very rare situations, also affect how transforms are parsed for regular DOM elements too (scaleY could be inverted) See https://greensock.com/forums/topic/27394-setting-gsaps-matrix-transform-data-to-match-that-defined-in-an-svg/

- FIXED: Draggables of type: "top,left" didn't properly update their deltaX property.

- FIXED: Draggables of type: "top,left" could, in rare circumstances, dispatch events as though it had been dragged even when it was only clicked (not moved beyond the minimumMovement). So the "onClick()" wouldn't fire on occasion.

- FIXED: if you create a timeline-based ScrollTrigger like gsap.timeline({scrollTrigger:{...}}) that performs pinning and then immediately create other ScrollTriggers for things further down on the page, and you do so AFTER the initial page load, the subsequent ScrollTriggers may not factor in the pinning properly until you call ScrollTrigger.refresh(). See https://greensock.com/forums/topic/27495-scrolltrigger-react-trouble-when-pinnings-multiple-elements-on-the-same-page/

- FIXED: there's a very rare scenario that could cause an infinite loop when you kill() the last ScrollTrigger, as described at #440

- FIXED: MotionPathHelper.editPath() correctly handles closed paths now (start and end anchors are merged).

- FIXED: if repeatRefresh was set on a repeating timeline, it could do the refresh twice in a row on the same tick (1 extra time). See https://greensock.com/forums/topic/27571-timeline-function-called-twice-per-loop/
@jackdoyle
Copy link
Member

Should be resolved in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants