Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storeforhumans.com - Demo parallax effect is not working #64112

Closed
webcompat-bot opened this issue Dec 22, 2020 · 8 comments
Closed

storeforhumans.com - Demo parallax effect is not working #64112

webcompat-bot opened this issue Dec 22, 2020 · 8 comments
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. type-js-scroll JS Scrolling performance issues
Milestone

Comments

@webcompat-bot
Copy link

webcompat-bot commented Dec 22, 2020

URL: https://storeforhumans.com/blogs/blog-for-humans/william-blake-sea-of-time-and-space

Browser / Version: Firefox 84
Operating System: Windows 10
Tested Another Browser: Yes Chrome

Problem type: Something else
Description: Demo of parallax effect stops working after refreshing; wrong effect
Steps to Reproduce:
The listed URL shows an adaptation of a painting so it creates a sense of depth for the user while scrolling in the browser. This effect works before refreshing the page; the effect disappears after refreshing the page. The strength of the effect also seems different i.e. less than in Google Chrome 87

Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added the action-needsmoderation The moderation has not yet been completed label Dec 22, 2020
@webcompat-bot webcompat-bot added this to the needstriage milestone Dec 22, 2020
@webcompat-bot webcompat-bot added the browser-fixme This requires manual assignment for the browser name label Dec 22, 2020
@webcompat-bot webcompat-bot changed the title In the moderation queue. storeforhumans.com - see bug description Dec 22, 2020
@webcompat-bot webcompat-bot added browser-firefox engine-gecko The browser uses the Gecko rendering engine and removed action-needsmoderation The moderation has not yet been completed browser-fixme This requires manual assignment for the browser name labels Dec 22, 2020
@softvision-oana-arbuzov softvision-oana-arbuzov changed the title storeforhumans.com - see bug description storeforhumans.com - Demo parallax effect is not working Dec 22, 2020
@softvision-oana-arbuzov softvision-oana-arbuzov added priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. labels Dec 22, 2020
@softvision-oana-arbuzov
Copy link
Member

Thanks for the report, I was able to reproduce the issue. It can be seen that the man dressed in red reaches the man in the water while scrolling down the page.
image

Tested with:
Browser / Version: Firefox Nightly 86.0a1 (2020-12-21)
Operating System: Windows 10 Pro

Moving to Needsdiagnosis for further investigation.

@karlcow karlcow added the type-js-scroll JS Scrolling performance issues label Feb 16, 2021
@karlcow
Copy link
Member

karlcow commented Feb 16, 2021

They are using
https://cdnjs.cloudflare.com/ajax/libs/gsap/3.4.2/ScrollTrigger.min.js

which register the event when loading the page with xa(Pe, 'mousewheel', Ia),

but mousewheel has been deprecated. if they replace by this line

`xa(Pe, 'wheel', Ia),`

The site will work as expected. Note that there is a bug for a legacy support of mousewheel.

The site is using

/*!
 * ScrollTrigger 3.4.2
 * https://greensock.com
 * 
 * @license Copyright 2020, GreenSock. All rights reserved.
 * Subject to the terms at https://greensock.com/standard-license or for Club GreenSock members, the agreement issued with that membership.
 * @author: Jack Doyle, jack@greensock.com
 */
!

Which is a library by @jackdoyle as mentioned in #57284

I opened an issue greensock/GSAP#434
and a pull request for it greensock/GSAP#435

@karlcow karlcow modified the milestones: needsdiagnosis, needscontact Feb 16, 2021
@webcompat-bot
Copy link
Author

@karlcow
Copy link
Member

karlcow commented Feb 16, 2021

If I'm not wrong the photo in the About Us of https://storeforhumans.com/pages/about-us
has similarities with @bjones3
if yes could you fix the site and replace mousewheel by wheel in scrolltrigger.js

Thanks.

@karlcow karlcow modified the milestones: needscontact, sitewait Feb 16, 2021
@bjones3
Copy link

bjones3 commented Feb 16, 2021

??????????

@karlcow
Copy link
Member

karlcow commented Feb 22, 2021

This is being fixed in the new version of the library.
greensock/GSAP#434 (comment)

@karlcow
Copy link
Member

karlcow commented Feb 22, 2021

@bjones3 you are a different Brian Jones? So sorry for bothering if it was the case, I will try to find the right person.

@softvision-raul-bucata
Copy link

The issue seems to be fixed. The layout of the change and colors of the picture has changed a bit, but the page orientation of the characters is the same.

Firefox:

Screenshot_1

Chrome:
Screenshot_2

Tested with:

Browser / Version: Firefox Nightly 102.0a1 (2022-05-03) (64-bit) / Chrome Version Version 101.0.4951.54 (Official Build) (64-bit)
Operating System: Windows 10 PRO x64

Closing this as FIXED.

[inv_18/2022]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox engine-gecko The browser uses the Gecko rendering engine priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect. type-js-scroll JS Scrolling performance issues
Projects
None yet
Development

No branches or pull requests

5 participants