Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failed on v2 #1699

Open
dadiorchen opened this issue Aug 1, 2023 · 5 comments
Open

CI failed on v2 #1699

dadiorchen opened this issue Aug 1, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@dadiorchen
Copy link
Collaborator

https://github.com/Greenstand/treetracker-web-map-client/actions/runs/5710704320/job/15471285207?pr=1698

@dadiorchen dadiorchen added the bug Something isn't working label Aug 1, 2023
@dadiorchen dadiorchen self-assigned this Aug 1, 2023
@dadiorchen
Copy link
Collaborator Author

@aayushgauba for this one, did you try to run the integration test locally, and how's the result.

@RubenSmn
Copy link
Member

RubenSmn commented Aug 2, 2023

The problem is with some cwm code, it is trying to fetch data from the server but that request isn't mocked. This was a isuse on the cwm branch as well but has been fixed by this pr #1688. However this pr is not yet included in the current v2 version.

The fix is on this commit

@aayushgauba
Copy link

@dadiorchen it fails on a 404 error it seems like, however not too sure

@dadiorchen
Copy link
Collaborator Author

@RubenSmn thank you!

@dadiorchen
Copy link
Collaborator Author

dadiorchen commented Aug 4, 2023

@aayushgauba I found the problem, basically, you need to go through the integration test locally and try to fix them all because of the change on the api side. Take a look at this commit I made for you, this fix the top.cy.js integration test.

aayushgauba@8b1aaf7

This seems tedious when you already done the developement but tests fail, actually, if you practice TDD, you wrote/modify your integration test first, then write the code, it goes smoothly

image

@dadiorchen dadiorchen removed their assignment Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants