Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ci test fail #1688

Merged
merged 71 commits into from
Jul 15, 2023
Merged

Fix/ci test fail #1688

merged 71 commits into from
Jul 15, 2023

Conversation

RubenSmn
Copy link
Member

ojafero and others added 30 commits December 8, 2022 16:06
refactor the badge component for better reusability
@RubenSmn RubenSmn changed the base branch from main to cwm July 10, 2023 09:58
@RubenSmn
Copy link
Member Author

@dadiorchen any idea why there are no tests running on this PR?

@dadiorchen
Copy link
Collaborator

@RubenSmn please change the branch here to star with quote:

@RubenSmn RubenSmn changed the base branch from cwm to main July 12, 2023 11:50
@RubenSmn RubenSmn changed the base branch from main to cwm July 12, 2023 11:52
@dadiorchen
Copy link
Collaborator

dadiorchen commented Jul 13, 2023

@RubenSmn great! Now I know what happened to unit test, I have solved this on the main branch, by upgrading cypress to 12, so you can merge the code from main, I think could solve this

.eslintrc.js Show resolved Hide resolved
Copy link
Collaborator

@dadiorchen dadiorchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenSmn I'm okay with this PR, thank you for this tedious job ;)

@dadiorchen
Copy link
Collaborator

Please merge if you think it is ready

@RubenSmn RubenSmn merged commit 01e9223 into Greenstand:cwm Jul 15, 2023
3 checks passed
@RubenSmn RubenSmn deleted the fix/ci-test-fail branch July 15, 2023 19:44
@github-actions
Copy link

🎉 This PR is included in version 2.6.1-cwm.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants