Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new icon spec. #71

Closed
dadiorchen opened this issue Jan 29, 2022 · 4 comments · Fixed by #73
Closed

Support the new icon spec. #71

dadiorchen opened this issue Jan 29, 2022 · 4 comments · Fixed by #73
Assignees

Comments

@dadiorchen
Copy link
Collaborator

Now we defined a new spec for the icon URL/route rule:

Use icon=o' query pamaeter rather than the path /new/` to choose the icon suite.

The spec details is here: https://greenstand.gitbook.io/wallet-web-app/tile-server-specification

So we need to modify the core to follow the new rule.

Here are some links for the design elements:

https://www.figma.com/file/XdYFdjlsHvxehlrkPVYq0l/Greenstand-Webmap?node-id=5336%3A19844

Tree icon:
https://www.figma.com/file/XdYFdjlsHvxehlrkPVYq0l/Greenstand-Webmap?node-id=6131%3A21214

Highlighted tree:
https://www.figma.com/file/XdYFdjlsHvxehlrkPVYq0l/Greenstand-Webmap?node-id=6133%3A21308

Selected tree:
https://www.figma.com/file/XdYFdjlsHvxehlrkPVYq0l/Greenstand-Webmap?node-id=6133%3A26944

Small size:
https://www.figma.com/file/XdYFdjlsHvxehlrkPVYq0l/Greenstand-Webmap?node-id=5336%3A19844

Basically, the big and small icons are just different in size, the shape is the same. The way I'm doing in tile server is: export the element from Figma, choose 3x size png, so the icon would be clear when I display it. I just need to shrink the image to get the correct icon:
for desktop:
transform: scale(0.33);

for mobile:
transform: scale(0.27);


Some hints:

  • Please read our readme for more information/guide/tutorial.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
@dadiorchen dadiorchen added the css label Jan 29, 2022
@dadiorchen
Copy link
Collaborator Author

@pratikmdhr can you take a look at this?

@dadiorchen
Copy link
Collaborator Author

https://dev-k8s.treetracker.org/tiles/1/1/1.png?icon=ptk-s
https://dev-k8s.treetracker.org/tiles/1/1/1.png?icon=ptk-b

And @pratikmdhr I observed some wired version switching problem on the tile, just as we saw before, I think there are some bug on the tile, sorry about the chaos.

@pratikmdhr
Copy link
Collaborator

Sure I'll look into this

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

🎉 This issue has been resolved in version 1.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants