VBA CFB test [ci skip]

grefel · Feb 5, 2018 · fb97bf1 · fb97bf1
1 parent 75845a0
commit fb97bf1
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 5 deletions.
diff --git a/bits/59_vba.js b/bits/59_vba.js
@@ -1,3 +1,4 @@
+var CT_VBA = "application/vnd.ms-office.vbaProject";
 function make_vba_xls(cfb/*:CFBContainer*/) {
 	var newcfb = CFB.utils.cfb_new({root:"R"});
 	cfb.FullPaths.forEach(function(p, i) {

diff --git a/bits/85_parsezip.js b/bits/85_parsezip.js
@@ -169,7 +169,7 @@ function parse_zip(zip/*:ZIP*/, opts/*:?ParseOpts*/)/*:Workbook*/ {
 	}
 	if(opts.bookVBA) {
 		if(dir.vba.length > 0) out.vbaraw = getzipdata(zip,strip_front_slash(dir.vba[0]),true);
-		else if(dir.defaults && dir.defaults.bin === 'application/vnd.ms-office.vbaProject') out.vbaraw = getzipdata(zip,'xl/vbaProject.bin',true);
+		else if(dir.defaults && dir.defaults.bin === CT_VBA) out.vbaraw = getzipdata(zip, 'xl/vbaProject.bin',true);
 	}
 	return out;
 }

diff --git a/test.js b/test.js
@@ -591,7 +591,10 @@ describe('parse options', function() {
 			var wb = X.read(fs.readFileSync(p), {type:TYPE}); assert(typeof wb.vbaraw === 'undefined');
 		}); });
 		it('bookVBA should generate vbaraw', function() { NFVBA.forEach(function(p) {
-			var wb = X.read(fs.readFileSync(p),{type:TYPE, bookVBA:true}); assert(wb.vbaraw);
+			var wb = X.read(fs.readFileSync(p),{type: TYPE, bookVBA: true});
+			assert(wb.vbaraw);
+			var cfb = X.CFB.read(wb.vbaraw, {type: 'array'});
+			assert(X.CFB.find(cfb, '/VBA/ThisWorkbook'));
 		}); });
 	});
 });

diff --git a/tests/core.js b/tests/core.js
diff --git a/xlsx.flow.js b/xlsx.flow.js
@@ -9175,6 +9175,7 @@ function write_comments_bin(data/*::, opts*/) {
 	write_record(ba, "BrtEndComments");
 	return ba.end();
 }
+var CT_VBA = "application/vnd.ms-office.vbaProject";
 function make_vba_xls(cfb/*:CFBContainer*/) {
 	var newcfb = CFB.utils.cfb_new({root:"R"});
 	cfb.FullPaths.forEach(function(p, i) {
@@ -18775,7 +18776,7 @@ function parse_zip(zip/*:ZIP*/, opts/*:?ParseOpts*/)/*:Workbook*/ {
 	}
 	if(opts.bookVBA) {
 		if(dir.vba.length > 0) out.vbaraw = getzipdata(zip,strip_front_slash(dir.vba[0]),true);
-		else if(dir.defaults && dir.defaults.bin === 'application/vnd.ms-office.vbaProject') out.vbaraw = getzipdata(zip,'xl/vbaProject.bin',true);
+		else if(dir.defaults && dir.defaults.bin === CT_VBA) out.vbaraw = getzipdata(zip, 'xl/vbaProject.bin',true);
 	}
 	return out;
 }

diff --git a/xlsx.js b/xlsx.js