Skip to content

Commit

Permalink
Fixes symfony#26136: Avoid emitting warning when hasParameterOption /…
Browse files Browse the repository at this point in the history
… getParameterOption is passed invalid parameters.
  • Loading branch information
greg-1-anderson committed Feb 12, 2018
1 parent aa3a04a commit e3fb107
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Symfony/Component/Console/Input/ArgvInput.php
Expand Up @@ -283,7 +283,7 @@ public function hasParameterOption($values)
// For long options, test for '--option=' at beginning
// For short options, test for '-o' at beginning
$leading = 0 === strpos($value, '--') ? $value.'=' : $value;
if ($token === $value || 0 === strpos($token, $leading)) {
if ($token === $value || !empty($leading) && 0 === strpos($token, $leading)) {
return true;
}
}
Expand Down Expand Up @@ -311,7 +311,7 @@ public function getParameterOption($values, $default = false)
// For long options, test for '--option=' at beginning
// For short options, test for '-o' at beginning
$leading = 0 === strpos($value, '--') ? $value.'=' : $value;
if (0 === strpos($token, $leading)) {
if (!empty($leading) && 0 === strpos($token, $leading)) {
return substr($token, strlen($leading));
}
}
Expand Down

0 comments on commit e3fb107

Please sign in to comment.