Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It be 2013 now #1937

Merged
merged 1 commit into from
Mar 2, 2013
Merged

It be 2013 now #1937

merged 1 commit into from
Mar 2, 2013

Conversation

iangcarroll
Copy link
Contributor

Just read the title.

Just read the title.
@seanlinsley
Copy link
Contributor

There's really no need for this PR. There are plenty of things in the codebase that need to be updated, and this is the least important of all of them. Just look at the number of outstanding Pull Requests and Issues.

@iangcarroll
Copy link
Contributor Author

I'm aware, but reviewing 1 number change and hitting merge can't be that bad.

@JazzJackrabbit
Copy link

Pull Request of the year. Literally.

@iangcarroll
Copy link
Contributor Author

@daxter If you'd like to cut down on outstanding requests, this would be the easiest, correct?

@seanlinsley
Copy link
Contributor

I don't have the permissions to merge your pull request.

My initial comment was really one of frustration intended for repo maintainers, as they're rarely around anymore. Again, look at all those Issues and Pull Requests.

@iangcarroll
Copy link
Contributor Author

Ah, I took that as directed to me. 

Sent from Mailbox for iPhone

On Sat, Feb 23, 2013 at 8:09 PM, Sean Ian Linsley
notifications@github.com wrote:

I don't have the permissions to merge your pull request.

My initial comment was really one of frustration intended for repo maintainers, as they're rarely around anymore. Again, look at all those Issues and Pull Requests.

Reply to this email directly or view it on GitHub:
#1937 (comment)

macfanatic added a commit that referenced this pull request Mar 2, 2013
@macfanatic macfanatic merged commit 0dbc5d5 into activeadmin:master Mar 2, 2013
@iangcarroll iangcarroll deleted the patch-3 branch March 2, 2013 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants