Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated admin_user file should be plural #1960

Closed
rmw opened this issue Mar 1, 2013 · 3 comments · Fixed by #1961
Closed

Generated admin_user file should be plural #1960

rmw opened this issue Mar 1, 2013 · 3 comments · Fixed by #1961

Comments

@rmw
Copy link
Contributor

rmw commented Mar 1, 2013

This is both consistent with the modal generator and prevents load errors.

I was writing a gem and testing against active_admin and got load errors on the admin_user path.

@seanlinsley
Copy link
Contributor

The standard seems to have changed so that all app/admin files are singular, hence why the Dashboard and AdminUser files are singular if you create a new project.

@seanlinsley
Copy link
Contributor

I personally prefer the singular form. It's more consistent with Rails naming conventions.

@rmw
Copy link
Contributor Author

rmw commented Mar 1, 2013

I got load errors with the singular in a rails app although it was a test app inside a gem, which could have some strange behavior (using rails plugin new --full). The errors were fixed by making the files plural.

But I understand where you're coming from. Our app started with an older version of ActiveAdmin and our models are plural, so I thought that was the standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants