Activeadmin admin#login page template should respect devise authentication_keys config #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setting instead of assuming default of 'email'
|
Thanks this looks great. I'll get this merged in today. |
gregbell
added a commit
that referenced
this pull request
May 25, 2011
Activeadmin admin#login page template should respect devise authentication_keys config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed activeadmin to a site where I had already implemented devise for authentication. I was getting an error because I had set my authentication key to a nondefault field ('login'):
config.authentication_keys = [ :login ]This is a one-line change to create the login page using the authentication keys setting rather than the hardcoded 'email' field to make it easier for projects already using devise to use activeadmin.