Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with server-side render and modules resolving #59

Closed
1 task done
Djelnar opened this issue Apr 4, 2018 · 1 comment · Fixed by #78
Closed
1 task done

Bug with server-side render and modules resolving #59

Djelnar opened this issue Apr 4, 2018 · 1 comment · Fixed by #78

Comments

@Djelnar
Copy link

Djelnar commented Apr 4, 2018 •
edited by gregberge
Loading

Getting react error when imported modules have same name but located in different folders e.g. index.js or page.js
reproduced in repo
please follow instruction
Preview of error

  • this is a bug
@gregberge
Copy link
Owner

Ah yes it is an edge case I have to solve!

gregberge added a commit that referenced this issue May 12, 2018
@gregberge
fix: fix module resolving
db3ebc3 
This issue fix #59

It is possible to create a configuration which will result into a wrong state but it should not happen in 99.99% cases.
@gregberge gregberge mentioned this issue May 12, 2018
Merged
gregberge added a commit that referenced this issue May 12, 2018
@gregberge
fix: fix module resolving
10318b0 
This issue fixes #59

It is possible to create a configuration which will result into a wrong state but it should not happen in 99.99% cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix module resolving gregberge/loadable-components
2 participants
@gregberge @Djelnar