fix: fix module resolving #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue fixes #59 It is possible to create a configuration which will result into a wrong state but it should not happen in 99.99% cases.
gregberge
force-pushed
the
fix-module-resolving
branch
from
db3ebc3
to
10318b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 88.54% 88.83% +0.29%
==========================================
Files 15 15
Lines 192 197 +5
Branches 50 53 +3
==========================================
+ Hits 170 175 +5
Misses 20 20
Partials 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue fixes #59
It is possible to create a configuration which will result into a wrong state but it should not happen in 99.99% cases:
If BC and EFG have the same name we could have a problem because we rely on the order of loading of A and D and it could be different on client and server.
Anyway this edge case is acceptable, issue will solve 99% of use-cases.