Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing default value for --no-view-box flag #71

Closed
rhys-vdw opened this issue Mar 29, 2018 · 3 comments
Closed

Confusing default value for --no-view-box flag #71

rhys-vdw opened this issue Mar 29, 2018 · 3 comments

Comments

@rhys-vdw
Copy link
Contributor

--no-view-box remove viewBox (default: true)

This is confusing since no view box = true would imply that the view box is stripped by default. Actually options.viewBox is true by default and --no-view-box sets it to false.

@gregberge
Copy link
Owner

Ah yes, this is an incoherence. For me all option should default to false, this is why there is some options that starts with --no. But fixing it will introduce a breaking change, OK for next version.

@rhys-vdw
Copy link
Contributor Author

It is defaulting to false. The only fix required is to update the docs. I think it would be clearer if it just said:

--no-view-box remove viewBox

@gregberge
Copy link
Owner

OK Thanks, you can submit a PR or someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants