Skip to content

Commit

Permalink
[3-2-stable] Port of rails#5522 'Fix adding/removing field's index wh…
Browse files Browse the repository at this point in the history
…en generating migration'
  • Loading branch information
mhfs authored and greggroth committed Mar 26, 2012
1 parent aa684d6 commit c8c4367
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
Expand Up @@ -24,6 +24,9 @@ def down
<% attributes.reverse.each do |attribute| -%>
<%- if migration_action -%>
<%= migration_action == 'add' ? 'remove' : 'add' %>_column :<%= table_name %>, :<%= attribute.name %><% if migration_action == 'remove' %>, :<%= attribute.type %><%= attribute.inject_options %><% end %>
<%- if attribute.has_index? && migration_action == 'remove' -%>
add_index :<%= table_name %>, :<%= attribute.index_name %><%= attribute.inject_index_options %>
<%- end -%>
<%- end -%>
<%- end -%>
end
Expand Down
18 changes: 18 additions & 0 deletions railties/test/generators/migration_generator_test.rb
Expand Up @@ -42,6 +42,24 @@ def test_add_migration_with_attributes
end
end

def test_remove_migration_with_indexed_attribute
migration = "remove_title_body_from_posts"
run_generator [migration, "title:string:index", "body:text"]

assert_migration "db/migrate/#{migration}.rb" do |content|
assert_method :up, content do |up|
assert_match(/remove_column :posts, :title/, up)
assert_match(/remove_column :posts, :body/, up)
end

assert_method :down, content do |down|
assert_match(/add_column :posts, :title, :string/, down)
assert_match(/add_column :posts, :body, :text/, down)
assert_match(/add_index :posts, :title/, down)
end
end
end

def test_remove_migration_with_attributes
migration = "remove_title_body_from_posts"
run_generator [migration, "title:string", "body:text"]
Expand Down

0 comments on commit c8c4367

Please sign in to comment.