Fix adding/removing field's index when generating migration #5522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing the field automatically removes the index, so we should skip the |
When generating a migration that removes a field with an index, the down will add both the field and its index.
|
Done! |
josevalim
added a commit
that referenced
this pull request
Mar 21, 2012
…dding_removing_index Fix adding/removing field's index when generating migration
mhfs
added a commit
to mhfs/rails
that referenced
this pull request
Mar 21, 2012
…en generating migration'
drogus
added a commit
that referenced
this pull request
Mar 22, 2012
Port of #5522 'Fix adding/removing field's index when generating migration'
greggroth
pushed a commit
to greggroth/rails
that referenced
this pull request
Mar 26, 2012
…en generating migration'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to generate a migration that removes a field with an index,
the up migration will remove both the field and the index, and the down
will re-add both the field and the index.
Also improved the indentation formatting of the generated migration.
I believe the existing functionality is not tested, so I'll add tests too.
Thanks,
Travis