New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blank line should not be required after closing backticks #59
Comments
Frog uses Pygments to syntax highlight. It looks like Pygments uses either Are you trying something like the following markdown?
On GitHub (which also uses Pygments) that results in: (ns foo.core
(:require foo.util))
(defn -main
[& args]
(doseq [name args]
(foo.util/greet name))) That also worked for me when I tried an example blog post in Frog. Do you:
|
I do have pygments installed (version 1.6) and the pigments.css is there in the folder. I've spent some time trying to narrow down the problem. It has nothing to do with the clojure and it looks like a bug in the engine. I've made several gists to demonstrate the problem. There are some tricks to get everything rendered well though: |
OK, I see. I'll take a look at my markdown grammar. It sounds like my grammar is requiring a blank line after the line with the closing backticks. I had thought that was correct. However it looks like a blank line is not required by GitHub nor by most implementations covered by BabelMark. Thank you for pointing this out. Also I'll update the title of this issue. |
No, actually my grammar already is not requiring a blank line after the closing backticks for a fenced code block. I just added unit tests for some of your exact examples, and they're passing. For example following passes: (check-md @~a{```
yo
```
```
yo
```
ABC
}
'((pre () "yo") (pre () "yo") "ABC")) However I did a big update to the markdown parser, just a couple days ago. I should make sure you have the latest version. If you're using Racket package managerPlease do
Did it update anything? If so, please try again. Is the problem still happening? If you're building from GitPlease pull the latest for all of the following repos: frog, markdown, parsack. Then try again, and let me know please? |
I use raco.
I still have the problem after doing the update. I'll try to build it from git and report the result here. |
When I said to try How about this instead: $ raco pkg install parsack
$ raco pkg update markdown I think that should do it. If not, would you mind running Although you could also build from git if you wish, you'll need to Again, the key point is to update the markdown parser, which in turn needs a new package called parsack. If you were installing frog from scratch it would work (I know from Travis CI testing). It's the update scenario I'm not 100% sure about, using the new Racket package manager. |
You probably need the |
Thanks @samth. So @Nek I think you want to try: $ raco pkg update --update-deps frog Or probably this would also work: $ raco pkg update --all I'm sorry for the confusion. The Racket package manager is still fairly new. I guess I need more experience with it, especially as a package user as opposed to a package developer. If things still aren't working, please do $ raco pkg show and paste the output here if you don't mind. That will show a checksum for each package, which may help me understand. |
The problem solved! Thanks a lot for paying all the attention. My frog was outdated (0.7) but
didn't work. Looks like
didn't work too but
fixed it for me! Here is the log:
|
Great, I'm glad it's working now. |
The text was updated successfully, but these errors were encountered: