Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing URL that isn't responding any more #10

Merged
merged 2 commits into from
Nov 6, 2017

Conversation

jeapostrophe
Copy link
Contributor

No description provided.

@samth
Copy link
Sponsor Contributor

samth commented Oct 29, 2017

https://www.yahoo.com definitely responds for me (and usually for the DrDr machine).

@jeapostrophe
Copy link
Contributor Author

jeapostrophe commented Oct 29, 2017 via email

@samth
Copy link
Sponsor Contributor

samth commented Oct 29, 2017

Yes. I suspect that just retrying a couple times would be sufficient, but removing it seems ok too.

@greghendershott
Copy link
Owner

I don't think I've ever seen the Yahoo test fail when run locally -- or from Travis CI.

One idea just popped into my head: I could try adding a User-Agent request header with a value like "racket" -- or even the value from a popular browser.

Rationale: Maybe yahoo.com has some sort of throttling for "anonymous" requests. Maybe it does not kick in for requests from a whitelist and Travis CI is on that list. Just a hunch.

Or I could just skip that and merge the PR as-is.

@greghendershott greghendershott self-assigned this Oct 29, 2017
@greghendershott greghendershott merged commit efcf9cd into greghendershott:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants