This repository has been archived by the owner on Jul 24, 2023. It is now read-only.
11ty version compatibility checking #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're good to merge this ✅ |
|
Hey @johnhunter sorry I was on holiday so didn't get a chance to review this pull request, it looks great though! |
|
Released in v0.3.1 |
|
Hey, no problem. Thanks for the release 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an 11ty version compatibility check. It allows our plugin to assert what versions of 11ty it is compatible with.
I've set it to fail with the next major release. This will give users a warning about what failed when they upgrade 11ty. On a new major version we will check compatibility, add tests, and increment the supported version.
I've set the minimum supported version very low - its basically a guess but we can change that if anyone reports an issue with a really old 11ty version.
Also refactored the
DEBUG_STRINGto use the package name.@gregives change requests welcome, otherwise I'll merge in a few days.