Fix usb-devices to work under busybox #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancsali
changed the title
The previous implementation relied on the -printf option for find, which is not implemented in BusyBox. Replaced it with sed to find the basenae of files reliably.
|
As the bot says, you need to sign off on your change :( |
|
@gregkh, thanks for reminding me. Just to confirm, what exact meaning do we attach to a commit being signed-off in this project? |
You need to add the following line to your path: Signed-off-by: Your Name <youremail.com> See the other commits as references. |
|
On Wed, Jan 17, 2024 at 03:21:46PM -0800, fabioestevam wrote:
> @gregkh, thanks for reminding me.
>
> Just to confirm, what exact meaning do we attach to a commit being signed-off in this project?
You need to add the following line to your path:
Signed-off-by: Your Name <youremail.com>
See the other commits as references.
That says what to do, but not what it means :)
This is following the DCO as created by the Linux kernel project, and
I'll document it better later today so as it makes more sense what you
are agreeing to when you add this line of text.
thanks,
greg k-h
|
|
@gregkh, did you, by any chance, get the opportunkty to update the documentation on this, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation relied on the -printf option for find, which is not implemented in BusyBox.
Replaced it with sed to find the basenae of files reliably.