Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply list indent size config to formatting ns #25

Merged
merged 2 commits into from Jan 16, 2020

Conversation

@egs33
Copy link
Contributor

egs33 commented Jan 10, 2020

Apply :list-indent-size to formatting ns. This config is added in #21. But, this is not applied to formatting ns.

@egs33 egs33 force-pushed the toyokumo:feature/list-indent-size-in-ns branch from ecd0e5f to 800201d Jan 10, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files          10       10           
  Lines        1154     1154           
  Branches       27       27           
=======================================
  Hits          852      852           
  Misses        275      275           
  Partials       27       27
Impacted Files Coverage Δ
core/src/cljstyle/format/ns.clj 96.46% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36eab29...800201d. Read the comment docs.

@egs33 egs33 marked this pull request as ready for review Jan 10, 2020
@greglook greglook added the bug label Jan 16, 2020
@greglook greglook self-assigned this Jan 16, 2020
Copy link
Owner

greglook left a comment

Thanks for fixing this. 👍

@greglook greglook merged commit d8cfbd4 into greglook:master Jan 16, 2020
6 checks passed
6 checks passed
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: style Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 73.83%)
Details
codecov/project 73.83% (+0%) compared to 36eab29
Details
@egs33 egs33 deleted the toyokumo:feature/list-indent-size-in-ns branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.