Skip to content

Commit

Permalink
build: allow ng_package patch to silently fail so that issue can be f…
Browse files Browse the repository at this point in the history
…ixed in angular repo

angular/angular#32603 will be fixed in angular/angular#33607 but the fix breaks this patch which breaks the material-unit-test job on that PR (https://app.circleci.com/jobs/github/angular/angular/515946). This change is temporary so that #33607 can land in angular.
  • Loading branch information
gregmagolan committed Nov 6, 2019
1 parent 69ccd34 commit f624702
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion tools/bazel/postinstall-patches.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,13 @@ searchAndReplace(
'node_modules/@angular/compiler-cli/src/ngtsc/entry_point/src/logic.js');

// Workaround for https://github.com/angular/angular/issues/32603.
shelljs.cat(path.join(__dirname, './rollup_windows_arguments.patch')).exec('patch -p0');
try {
shelljs.cat(path.join(__dirname, './rollup_windows_arguments.patch')).exec('patch -p0');
} catch (_) {
// This is getting fixed in ng_rollup_bundle itself but due to the dependency sandwich
// between this repo and the material-unit-test job in the angular repo we need to add
// this try/catch here temporarily.
}

// Workaround for: https://hackmd.io/MlqFp-yrSx-0mw4rD7dnQQ?both. We only want to discard
// the metadata of files in the bazel managed node modules. That way we keep the default
Expand Down

0 comments on commit f624702

Please sign in to comment.