-
Notifications
You must be signed in to change notification settings - Fork 27.1k
bazel: ng_package rule not working with too much rollup globals on windows #32603
Copy link
Copy link
Closed
Labels
area: bazelIssues related to the published `@angular/bazel` build rulesIssues related to the published `@angular/bazel` build ruleshotlist: components teamRelated to Angular CDK or Angular MaterialRelated to Angular CDK or Angular Material
Milestone
Description
🐞 bug report
Affected Package
@angular/bazel
Is this a regression?
No
Description
The ng_package rule does not work on Windows if there are too many rollup
globals. This is because the rollup globals are passed to rollup through command
line arguments. This is problematic as on windows the command line argument
is very low and some globals/arguments might be omitted.
Depending on what flags are getting through and the amount of characters which
are accidentally omitted from the arguments, this can either cause an exception to
be thrown, or a successful build which misses some flags or globals.
Anything else relevant?
Similar to bazel-contrib/rules_nodejs#1120. I just submitted this here as well because the ng_package rule launches the rollup binary on its own.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area: bazelIssues related to the published `@angular/bazel` build rulesIssues related to the published `@angular/bazel` build ruleshotlist: components teamRelated to Angular CDK or Angular MaterialRelated to Angular CDK or Angular Material