Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect V3 deprecation message for onRowsExpand #1402

Closed
dmbarry86 opened this issue Jul 10, 2020 · 1 comment
Closed

Incorrect V3 deprecation message for onRowsExpand #1402

dmbarry86 opened this issue Jul 10, 2020 · 1 comment

Comments

@dmbarry86
Copy link

Description

In version 3, the onRowsExpand option is being deprecated in favour of the new onRowExpansionChange option. However, the deprecation warning in the console appears to be incorrect and mentions onRowsSelect instead of onRowsExpand.

Expected behaviour

Deprecation Notice: onRowsExpand has been renamed onRowExpansionChange. More info: https://github.com/gregnb/mui-datatables/tree/master/docs/v2_to_v3_guide.md

Actual behaviour

Deprecation Notice: onRowsSelect has been renamed onRowExpansionChange. More info: https://github.com/gregnb/mui-datatables/tree/master/docs/v2_to_v3_guide.md

@patorjk
Copy link
Collaborator

patorjk commented Jul 10, 2020

Thank you for the report! I'll have this fixed in the next version (3.2.0), which should come out next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants