Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring TableFooter #1349

Merged
merged 5 commits into from
Jul 9, 2020
Merged

Conversation

wdh2100
Copy link
Collaborator

@wdh2100 wdh2100 commented Jun 19, 2020

Refactor from class component to functional component

ref : #1346

Sorry. When I split it in PR, it's lot..

codeSandBox : http://codesandbox.io/s/github/wdh2100/mui-datatables/tree/functional/tableFooter

@coveralls
Copy link

coveralls commented Jun 19, 2020

Coverage Status

Coverage increased (+0.1%) to 73.112% when pulling 61fa2f0 on wdh2100:functional/tableFooter into 6891ed2 on gregnb:v3_1_0.

@@ -1,9 +1,7 @@
import React from 'react';
import { spy, stub } from 'sinon';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary codes

@patorjk
Copy link
Collaborator

patorjk commented Jun 22, 2020

@wdh2100 Can you verify that you ran "npm run test"? I had some issues but realized it they were already in the v3.1.0 branch (so not related to you). It's kind of late, so I'm thinking of saving the rest of these for next week's release. However, looks like I can't test from codesandbox so figured I'd ask before doing the merge.

@wdh2100
Copy link
Collaborator Author

wdh2100 commented Jun 22, 2020

What is the problem?
When I run 'npm run test' it works fine

asdasd

@wdh2100
Copy link
Collaborator Author

wdh2100 commented Jun 22, 2020

but mocha.opts <--- deprecated

ref : https://github.com/mochajs/mocha/releases/tag/v8.0.0

@wdh2100 wdh2100 changed the base branch from v3_1_0 to v3.2.0 June 26, 2020 11:05
@wdh2100
Copy link
Collaborator Author

wdh2100 commented Jun 26, 2020

Rebase v3.2.0

@patorjk
Copy link
Collaborator

patorjk commented Jul 9, 2020

Thank you for adding the tests. I have a footer feature I want to add for version 3.2.0. I'm going to merge this branch into the jumpToPage branch and work on it there.

@patorjk patorjk changed the base branch from v3.2.0 to jumpToPage July 9, 2020 16:07
@patorjk patorjk merged commit 720ce0b into gregnb:jumpToPage Jul 9, 2020
@wdh2100 wdh2100 deleted the functional/tableFooter branch July 10, 2020 00:36
@wdh2100
Copy link
Collaborator Author

wdh2100 commented Jul 10, 2020

@patorjk

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants